Added hit animations, updated lighting & added InteliJ to gitignore #71
Conversation
|
Thanks for taking care of this! There are a couple of bugs:
osu! also has a kind of bouncy effect when you hit a circle, and it feels a little off seeing just a linear size growth. There's a copyright issue, as well -- peppy has copyright on all the default osu! skin images, so I can't actually include the |
|
This is the lighting texture I use in my own skin, so this one should be fine. I'll get to work on those bugs right away |
|
I'm not quite sure what you mean by bounciness, but it definitely does look like there is some easing (60fps at 30% speed) Update: Progress has been made! The slider results now finish at the same time. Found a bug, not sure if it existed before. The result number doesn't appear on repeated sliders. Looking into that now, then I'll add easing. I've also noticed that the slider fades out with the hit animation, but I will look into implementing that after #64. |
|
@lemonlake just implement whatever you need on top of the current slider system (something almost exactly like it will still exist as a fallback anyway), I'll rebase however necessary. |
|
New bug: Geki and katu hit results no longer appear. Know why it occurs and how to solve it, just looking into how to implement it. |
|
|
||
| public enum HitResultType { | ||
| CIRCLE, | ||
| SLIDERSTART, |
There was a problem hiding this comment.
That was going to be used, but I never actually used it. I left it in there in the event that anyone in the future wanted to use it.
|
This looks really great now -- thanks again! I added a few comments in the diff, but visually this seems perfect. Are you ready for me to merge it? |
|
I'll just fix those and then it will be ready! |
|
Go ahead and merge! |
Added hit animations, updated lighting & added InteliJ to gitignore
- Fixed a major bug where two hit result calculations were being performed for each slider. - Fixed a bug where hit circles/sliders were being drawn for a miss. - Sliders now only expand when held to the end (as in osu!). - Use the track position as the hit result start time for circles (instead of the object time). - Added a 'color' parameter to Curve.draw(), rather than keeping an extra reference to the slider Color object. - Renamed HitResultType enum to HitObjectType, and moved it into GameData. - Removed some overloaded methods (not really necessary...). - Other style changes. Signed-off-by: Jeffrey Han <itdelatrisu@gmail.com>
I hope I did this right ._. pardon the IntelliJ typo